fix: update donut clusters on source data (DHIS2-11923) #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
approved these changes
Oct 4, 2021
dhis2-bot
added a commit
that referenced
this pull request
Oct 4, 2021
## [2.1.4](v2.1.3...v2.1.4) (2021-10-04) ### Bug Fixes * update donut clusters on source data ([#403](#403)) ([17ea982](17ea982))
|
🎉 This PR is included in version 2.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-11923
This PR makes sure the donut clusters are updated when the layer data source is changed. Waiting for evt.isSourceLoaded is not reliable, and we keep the listener until the layer is removed.
The maplibe-gl dependency is upgraded to latest 1.15.x version.
After this PR all donut cluster are shown when the layer is loaded:
Before only the single events where displayed before map interaction: